Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major version bump tracking issue #666

Closed
1 of 3 tasks
rondale-sc opened this issue Jan 16, 2019 · 5 comments
Closed
1 of 3 tasks

Major version bump tracking issue #666

rondale-sc opened this issue Jan 16, 2019 · 5 comments

Comments

@rondale-sc
Copy link
Collaborator

rondale-sc commented Jan 16, 2019

This is an issue meant to track the next major version since the build tooling along with a few other changes represent a possible breaking changes to consumers of the addon:

More to follow

@kevinansfield
Copy link
Collaborator

I'd really like to see #658 land if a major version bump is planned. It has some behaviour changes so not strictly a patch although IMO it is mostly fixing buggy behaviour, it's the reason we're currently using a fork including this change at Ghost.

I think it's ready to go but I have a couple of additional verification tests, I'll take a look at those asap.

@rondale-sc
Copy link
Collaborator Author

@kevinansfield Added to the list! 💯

@ErisDS
Copy link
Contributor

ErisDS commented Jan 21, 2019

I've commented on #664 which is already listed, that it would be great if mobiledoc-kit could start to be broken down into some smaller pieces. Possibly beyond scope, but if there are any possible quick wins after removing circular dependencies, it would be great to see them considered.

Essentially the need comes from making the mobiledoc format an essential part of our product. We therefore need to have supporting tooling, not just in the editor, but in our API, migration, import/export, upgrade handling and other use cases, that will likely only depend on a small subset of the full kit.

@mixonic
Copy link
Contributor

mixonic commented Jan 22, 2019

Strong agree on #658.

@ErisDS the work @iezer and @rondale-sc were doing should improve the ability to import the ES modules from mobiledoc-kit directly. I think that is the quickest of quick wins. Bustle has some similar concerns, as they do a lot of import and manipulation of Mobiledoc files.

Specifically @rondale-sc is working up an example of how to use the models and serializer directly and without booting the editor itself. There might be small code tweaks, but mostly we're talking about making the internals a bit better documented and supported.

@gpoitch
Copy link
Member

gpoitch commented Aug 31, 2022

Closing as aged maintainer meta. Individual issues are tracked

@gpoitch gpoitch closed this as not planned Won't fix, can't repro, duplicate, stale Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants