Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A value type to hold arbitrary JSON5 #3

Closed
callum-oakley opened this issue Nov 30, 2018 · 3 comments
Closed

A value type to hold arbitrary JSON5 #3

callum-oakley opened this issue Nov 30, 2018 · 3 comments

Comments

@callum-oakley
Copy link
Owner

We should provide a value type in the style of serde_json's.

Prerequisite for #2.

@zonyitoo
Copy link
Contributor

What's the status of this issue?

@callum-oakley
Copy link
Owner Author

Not started, but will try and find the time to take a look at it in the next few days. Thanks for the reminder!

@callum-oakley
Copy link
Owner Author

@vdonich alerted me to the fact that serde_json::Value works perfectly well with json5, what with serde being interoperable and all.

For example, something like this seems to work absolutely fine:

let value = json5::from_str::<serde_json::Value>(&buffer);

I would still like to address #2 so we can write json5 in a macro, but assuming nobody finds any issues with deserialising in to serde_json::Value I think this issue can probably be closed. (@zonyitoo pinging you in case this is still relevant, I realise it was a while ago!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants