Unused function reported as "Unused assignment"

[hauserx]

Possibly that's issue with implementation in starlark-rust, but filling for now here before investigating further:

Example message in python checker:
local variable 'x' is assigned to but never used

[cameron-martin]

Yeah it looks like starlark-rust treats defs as assignments. I suppose they kind of are, but it doesn't make for a very good error message.

[hauserx]

For variables also unused assignment may not be the best message:

I think it should be "Unused variable" for vars - https://github.com/bazelbuild/starlark/blob/master/spec.md#assignments

For functions it could be "Unused variable" (as Following spec https://github.com/bazelbuild/starlark/blob/master/spec.md#function-definitions ), but probably "Unused function" should be acceptable as def always declare a function.

[hauserx]

Adding yet another message that possibly can be improved (Used ignored variable).
In this case variable _a is not defined at all, so message that using some ignore value is confusing.