Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust all tests of cloud-cap-samples to start test server inside describ #1215

Open
gregorwolf opened this issue Aug 27, 2024 · 1 comment
Assignees

Comments

@gregorwolf
Copy link
Collaborator

Hello CAP Documentation Team,

with #1068 the CAPire documentation on Testing with cds.test was adjusted in the section Running a CAP Server that the cds.test should be started inside a describe:

const cds = require('@sap/cds')
describe(()=>{
  const test = cds.test(__dirname+'/..')
})

Not all tests in https://github.com/SAP-samples/cloud-cap-samples/tree/main/test follow this best practice. I think this needs to be adjusted. For cap-sflight I've filed SAP-samples/cap-sflight#1177.

Best Regards
Gregor

@smahati
Copy link
Contributor

smahati commented Sep 2, 2024

Hi Gregor,

Thank you for reporting the issue, I'll check and update as necessary.

Best regards,
Mahati

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants