Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eslint warnings and errors #25

Open
iconben opened this issue Oct 8, 2024 · 3 comments · Fixed by #63
Open

Eslint warnings and errors #25

iconben opened this issue Oct 8, 2024 · 3 comments · Fixed by #63
Assignees
@KurumiFrost
Labels
enhancement Improvements to existing feature

Comments

@iconben
Copy link
Member

iconben commented Oct 8, 2024

Though an ad-hod fix (commit 8a25dd79f58c6dc4d4f4491e310a25564c0a0fd7) temporarily fixed it, this still need to be fixed.
@iconben iconben added the enhancement Improvements to existing feature label Oct 8, 2024
@KurumiFrost KurumiFrost mentioned this issue Oct 9, 2024
Closed
1 task
@iconben
Copy link
Member Author

iconben commented Oct 20, 2024 •
edited
Loading

Remove this line in the next.config.mjs:

ignoreDuringBuilds: true,

Then run this command to reproduce:

npm run build

@iconben iconben linked a pull request Oct 20, 2024 that will close this issue
fix: automatically fix most eslint errors in build time #63
Merged
@iconben
Copy link
Member Author

iconben commented Oct 20, 2024 •
edited
Loading

@KurumiFrost
By npx eslint . --fix we have fixed most of the errors, but there are still several remaining.

@iconben iconben reopened this Oct 25, 2024
@iconben
Copy link
Member Author

iconben commented Oct 25, 2024 •
edited
Loading

Remove this line in the next.config.mjs:

ignoreDuringBuilds: true,

Then run this command to reproduce:

npm run build

Need to fix other remaining issues by following such steps to reproduce the eslint errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KurumiFrost KurumiFrost

Labels
enhancement Improvements to existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: automatically fix most eslint errors in build time carinachain/dotcom-website
2 participants
@iconben @KurumiFrost