Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve container generation workflow section #230

Open
aturner-epcc opened this issue Jul 29, 2024 · 0 comments
Open

Improve container generation workflow section #230

aturner-epcc opened this issue Jul 29, 2024 · 0 comments
Assignees
@aturner-epcc
Labels
peer review:editorial comment Editorial comments to be addressed from the peer review

Comments

@aturner-epcc
Copy link
Contributor

From the lesson peer review

In chapter 6 there is a title that says 'Boring but important notes about the installation': I think this section is far more important than what is mentioned in the title. Basically, you are proposing a workflow to develop a Dockerfile.

You introduce the flags --rm and --name in a previous chapter. Would you suggest using them as part of a Docker use workflow?
@aturner-epcc aturner-epcc added the peer review:editorial comment Editorial comments to be addressed from the peer review label Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aturner-epcc aturner-epcc

Labels
peer review:editorial comment Editorial comments to be addressed from the peer review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aturner-epcc