Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for instructions on opening a pull request #400

Open
svenvanderburg opened this issue Oct 22, 2024 · 0 comments
Open

Improvements for instructions on opening a pull request #400

svenvanderburg opened this issue Oct 22, 2024 · 0 comments

Comments

@svenvanderburg
Copy link
Collaborator

1. Merge to main or dev?

In this paragraph 'Raising a pull request': https://carpentries-incubator.github.io/python-intermediate-development/41-code-review/index.html#raising-a-pull-request . In point 4 we say: Select the base and the compare branch - main and feature-std-dev, respectively. In the screenshots the merge is to the dev branch however. I would suggest to merge into dev here.

2. Adapt for forked repo

The screenshots and instructions show the situation in the original repo. But participants work in a forked repo. The screenshots should reflect this. And make it very clear that they should not open a PR to the forked repo, which is the default in GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant