Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search box not working in published lessons #547

Closed
ocaisa opened this issue Nov 22, 2023 · 3 comments
Closed

Search box not working in published lessons #547

ocaisa opened this issue Nov 22, 2023 · 3 comments
Labels
duplicate This issue or pull request already exists

Comments

@ocaisa
Copy link
Contributor

ocaisa commented Nov 22, 2023

The search boxes in (at least):

do not work. Clicking on the search box (in Chrome and Firefox) does not allow you to write text, and the search button does not work.

@klbarnes20
Copy link
Contributor

Thank you for sharing this @ocaisa. Search is not currently operational in the workbench and is something we are working on. Please see #495 and carpentries/varnish#86. Unfortunately, I cannot give you a timeline for when this will be operational, but know that it is on our radar.

@ocaisa
Copy link
Contributor Author

ocaisa commented Nov 22, 2023

Thanks for the update, in terms of UX it may be better to hide the search bar for the time being until the feature is actually supported.

@klbarnes20 klbarnes20 added the duplicate This issue or pull request already exists label Nov 22, 2023
@zkamvar
Copy link
Contributor

zkamvar commented Nov 22, 2023

Thank you. This is being discussed in carpentries/workbench#8

We are aware of this problem and we are aware of the many potential solutions to it. I am going to close this issue as duplicate of the workbench issue.

@zkamvar zkamvar closed this as not planned Won't fix, can't repro, duplicate, stale Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants