Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to cairo-sha256 #5

Open
tarrencev opened this issue Aug 29, 2022 · 2 comments
Open

Migrate to cairo-sha256 #5

tarrencev opened this issue Aug 29, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@tarrencev
Copy link
Contributor

We currently use a fully onchain sha256 hashing algorithm to hashing the signed payload. We should migrate to https://github.com/cartridge-gg/cairo-sha256 once the hints are whitelisted, which provides an ~order of magnitude reduction in sha256 gas costs.

@tarrencev tarrencev added the enhancement New feature or request label Aug 29, 2022
@piniom
Copy link
Collaborator

piniom commented Feb 28, 2024

Hi @tarrencev, is this still applicable to our cairo1 code?

@tarrencev
Copy link
Contributor Author

@ThePinion we do still want to do this i think. IIRC, the current sha256 implementation doesn't parallelize the rounds by packing them into the felt252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants