Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing upgrade.php #125

Open
keevan opened this issue Sep 4, 2024 · 0 comments
Open

Testing upgrade.php #125

keevan opened this issue Sep 4, 2024 · 0 comments

Comments

@keevan
Copy link
Contributor

keevan commented Sep 4, 2024

Would be super useful to have a check that tests the "upgrade" path.

This could be triggered when there are changes detected in db/upgrade.php, to avoid slowing down test times for non DB related upgrades.

This will catch any issues resulting from things such as incompatible DB queries that pop up across different DB engines (e.g. mysql vs postgres etc) that might not be thoroughly tested due to natural bias. A recent one was detected for excimer and raised by @x-iy via internal chat.

This should be resolved upstream in the main CI checker here - moodlehq/moodle-plugin-ci#180 , and in doing so, changes in upgrade.php would be checked to confirm it won't break during a real upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant