Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check environment.xml for DB minimums and ensure services are registered accordingly #57

Open
2 tasks
keevan opened this issue Jul 26, 2022 · 0 comments
Open
2 tasks
Labels
enhancement New feature or request

Comments

@keevan
Copy link
Contributor

keevan commented Jul 26, 2022

I'm happy to get this over the line so the tests can resume as normal, but ideally it would use a higher version of:

  • the test matrix
  • or sniffing it out via the environment.xml or similar to deduce the minimum DB version requirements for the branch.

Allowing this to be dynamic would be a nice to have, and might reduce the need to update this periodically. But that can be pushed down the road if we can get this working again relatively easily.

I'll split this into another enhancement issue.

Originally posted by @keevan in #56 (comment)

  • Deduce the minimum from the environment.xml (or similar) of the moodle branch, and supply it back when creating the DB services
  • Use both the 'includes matrix' and environment to dynamically deduce the most appropriate DB version to use for testing the branch. In future, we'd bump the minimums in the 'includes matrix' if we think a higher versioned DB would perform better, but this isn't a strict requirement.
@keevan keevan added the enhancement New feature or request label Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant