Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update readme to include steps to test and confirm changes for a PR #85

Open
keevan opened this issue Jan 4, 2023 · 0 comments
Open

Comments

@keevan
Copy link
Contributor

keevan commented Jan 4, 2023

This will be helpful for the reviewer, as well as the person creating the change.

This allows the changes to be fully tested and confirmed working.

How:

The options introduced to assist with this process is internal_workflow_branch (https://github.com/catalyst/catalyst-moodle-workflows/blob/main/.github/workflows/ci.yml#L7-L10)

So in the plugin branch, you would create or update the ci.yml file (as per current docs) in a new test branch, and set the with option internal_workflow_branch to the branch being PR'd in this repository.

It will then run the actions using the new branch, instead of the (default) main branch.

The person making the changes will then link these tests / references in their PR as part of their changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant