Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SFTP step private pub key auth not working #832

Open
keevan opened this issue Aug 31, 2023 · 0 comments
Open

SFTP step private pub key auth not working #832

keevan opened this issue Aug 31, 2023 · 0 comments
Assignees
@dmitriim
Labels
bug Something isn't working

Comments

@keevan
Copy link
Contributor

keevan commented Aug 31, 2023

moodle-tool_dataflows/classes/local/step/sftp_trait.php

Line 300 in 4c83e2e

if (!empty($config->privkeyfile)) {

There might have been some changes made since. $config here hasn't been provided anywhere, so it will never enter the block and thus private/pub key auth won't work.
@keevan keevan added the bug Something isn't working label Aug 31, 2023
dmitriim added a commit that referenced this issue Aug 31, 2023
@dmitriim
[#832] fix the issue when private key was never used
f5d28ce
dmitriim added a commit that referenced this issue Aug 31, 2023
@dmitriim
[#832] fix the issue when private key was never used
7358e5a
dmitriim added a commit that referenced this issue Aug 31, 2023
@dmitriim
[#832] fix the issue when private key was never used
3079937
keevan added a commit that referenced this issue Aug 31, 2023
@keevan
Merge pull request #834 from catalyst/issue832-non-breaking
955da56 
[#832] fix the issue when private key was never used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitriim dmitriim

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmitriim @keevan