Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad configuration on a step should not prevent the user from being able to fix it from the UI #898

Open
keevan opened this issue Sep 24, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@keevan
Copy link
Contributor

keevan commented Sep 24, 2024

For example, setting an expression for a SFTP step's private key path field, may not cause issues with validation, but may cause the dataflow to fail to load the "view.php" page, and the user cannot navigate to edit the step.

Sometimes, it affects the variable tree, and so editing the step values itself, may become "impossible", and so the step needs to be deleted and recreated.

Ideally, both scenarios shouldn't happen, and validation kicks in before the step is saved. But if the step's validation doesn't catch a particular usecase, then it should be resolvable from the UI.

I suspect the variable tree section should be wrapped to not display on error, but still allow the rest of the page to load and the user to submit corrected information.

If the dataflow chart fails to render the full flow because of some dataflow variable/expression issue, then similarly it should show an error, but still allow the user to edit steps and resolve possible issues.

@keevan keevan added the bug Something isn't working label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant