From 404bb08767342cfcbe6d41c76ff06572c936dfe0 Mon Sep 17 00:00:00 2001
From: William Ridgeway <10358980+wrridgeway@users.noreply.github.com>
Date: Wed, 23 Oct 2024 13:36:29 -0500
Subject: [PATCH] Update `cdu` and `user16` documentation (#628)

* Add alternative cdu column

* Additional documentation

* Sort column names

* Fix shared column name

* Update cdu documentation
---
 dbt/models/iasworld/schema/iasworld.comdat.yml  |  2 ++
 dbt/models/iasworld/schema/iasworld.dweldat.yml |  2 ++
 dbt/models/iasworld/schema/iasworld.oby.yml     |  2 +-
 dbt/models/shared_columns.md                    | 17 +++++++++++++----
 4 files changed, 18 insertions(+), 5 deletions(-)

diff --git a/dbt/models/iasworld/schema/iasworld.comdat.yml b/dbt/models/iasworld/schema/iasworld.comdat.yml
index c3ad37905..62b38cc61 100644
--- a/dbt/models/iasworld/schema/iasworld.comdat.yml
+++ b/dbt/models/iasworld/schema/iasworld.comdat.yml
@@ -396,6 +396,8 @@ sources:
             description: Number of units
           - name: upd_status
             description: '{{ doc("column_upd_status") }}'
+          - name: user16
+            description: '{{ doc("shared_column_alternative_cdu") }}'
           - name: useradj
             description: Override to comdat userdef adjustment factor
           - name: valmeth
diff --git a/dbt/models/iasworld/schema/iasworld.dweldat.yml b/dbt/models/iasworld/schema/iasworld.dweldat.yml
index 2472032e1..8d4043a30 100644
--- a/dbt/models/iasworld/schema/iasworld.dweldat.yml
+++ b/dbt/models/iasworld/schema/iasworld.dweldat.yml
@@ -1396,6 +1396,8 @@ sources:
                   config: *unique-conditions
                   meta:
                     description: user15 (Use) should not be null
+          - name: user16
+            description: '{{ doc("shared_column_alternative_cdu") }}'
           - name: user17
             description: Age. Deprecated, use `yrblt`
           - name: user20
diff --git a/dbt/models/iasworld/schema/iasworld.oby.yml b/dbt/models/iasworld/schema/iasworld.oby.yml
index ad61986de..277322bd7 100644
--- a/dbt/models/iasworld/schema/iasworld.oby.yml
+++ b/dbt/models/iasworld/schema/iasworld.oby.yml
@@ -449,7 +449,7 @@ sources:
           - name: upd_status
             description: '{{ doc("column_upd_status") }}'
           - name: user16
-            description: '{{ doc("shared_column_cdu") }}'
+            description: '{{ doc("shared_column_alternative_cdu") }}'
           - name: valmeth
             description: Valuation Method (R(CLT/RES) or M(MSB))
           - name: vect
diff --git a/dbt/models/shared_columns.md b/dbt/models/shared_columns.md
index afac07308..1d479e3e0 100644
--- a/dbt/models/shared_columns.md
+++ b/dbt/models/shared_columns.md
@@ -186,6 +186,17 @@ Reason for change or no change
 
 # Assessed / Market Values
 
+## alternative_cdu
+
+{% docs shared_column_alternative_cdu %}
+Condition/Desirability/Utility code.
+
+Code representing any number of seemingly unrelated characteristics
+associated with a PIN, ranging from condition to types of subsidies, to
+whether or not a PIN is a garage. The full list of CDU codes can be found in
+`ccao.cdu`. For "condition", see the `cdu` column.
+{% enddocs %}
+
 ## board_bldg
 
 {% docs shared_column_board_bldg %}
@@ -852,10 +863,8 @@ Equivalent to legacy `MLT_CD` (multicode) value
 {% docs shared_column_cdu %}
 Condition/Desirability/Utility code.
 
-Code representing any number of seemingly unrelated characteristics
-associated with a PIN, ranging from condition to types of subsidies, to
-whether or not a PIN is a garage. The full list of CDU codes can be found on
-the Assessor's site
+The `cdu` column only documents "condition". See `user16` for what the
+Assessor's office typically considers the Condition/Desirability/Utility code.
 {% enddocs %}
 
 ## class