Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set colors in preferences dialog #134

Open
cdepillabout opened this issue Oct 19, 2019 · 0 comments
Open

set colors in preferences dialog #134

cdepillabout opened this issue Oct 19, 2019 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@cdepillabout
Copy link
Owner

cdepillabout commented Oct 19, 2019

PR #130 (for issue #82) implemented a preferences dialog. It would be convenient to have a way to set console colors from the preferences dialog.

The preferences dialog currently looks like this:

image

It would be nice to add another tab to the preferences dialog so that it could set colors.

For reference, here is the color-setting dialog from Roxterm:

image

Although I think this is somewhat confusing. I would prefer it to look more like the output of the print-console-colors command, but each color would be editable:

image


In order to implement this, you'd need to do the following:

  1. Create something like a notebook with multiple tabs for the preferences dialog:

    <child internal-child="vbox">

    You should probably use Glade for doing this. It is pretty easy to use even if you've never used it.

  2. Make the current preferences dialog the first tab.

  3. Add a new tab for setting the colors. I'm not sure what the best layout for this would be, but something that allows the user to easily set all 256 would be ideal. Creating this layout programatically would probably be easier than doing it with Glade. Here's the function that shows the preferences dialog. This is what you'd need to edit if you're doing it programatically:

    showPreferencesDialog :: TMState -> IO ()

@cdepillabout cdepillabout added enhancement New feature or request help wanted Extra attention is needed labels Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant