Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set non-string values #2

Open
paul-hansen opened this issue Sep 13, 2023 · 3 comments
Open

Ability to set non-string values #2

paul-hansen opened this issue Sep 13, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@paul-hansen
Copy link

Thanks for making this crate, it's almost exactly what I was looking for.

Currently

tomato set language-server.rust-analyzer.config.cargo.noDefaultFeatures true ./.helix/languages.toml

Results in:

[language-server.rust-analyzer.config.cargo]
noDefaultFeatures = "true"

Note that true is a string not a boolean value. Ideally if I don't provide quotes around the value it would try to parse boolean, int and floats from the value and fallback to being a string if it isn't one of those types. Supporting times would be nice too for completeness, but possibly more work and not near as common as the others.

@ceejbot ceejbot added the bug Something isn't working label Sep 24, 2023
@ceejbot ceejbot self-assigned this Sep 24, 2023
@ceejbot
Copy link
Owner

ceejbot commented Sep 24, 2023

This is an excellent suggestion!

@ceejbot
Copy link
Owner

ceejbot commented Sep 24, 2023

Implemented in e4d1998

I think this gets a major number bump because it changes command-line behavior.

@ceejbot ceejbot closed this as completed Sep 24, 2023
@ceejbot ceejbot reopened this Sep 24, 2023
@ceejbot
Copy link
Owner

ceejbot commented Sep 24, 2023

Oh oh oh I should leave this open because I think handling date-time is possible too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants