Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CentrifugeConnectEvent has not data property #66

Closed
shalom-aviv opened this issue May 18, 2022 · 4 comments
Closed

CentrifugeConnectEvent has not data property #66

shalom-aviv opened this issue May 18, 2022 · 4 comments

Comments

@shalom-aviv
Copy link
Contributor

Delegate.swift:

//...
public struct CentrifugeConnectEvent {
    public var client: String
}
//...

Specification Connect result fields:

Field Type Optional Description
data JSON yes a custom data to send to the client in connect command response.

In Java all is OK ;)

ConnectEvent.java

package io.github.centrifugal.centrifuge;

public class ConnectEvent {
    public String getClient() {
        return client;
    }

    void setClient(String client) {
        this.client = client;
    }

    public byte[] getData() {
        return data;
    }

    void setData(byte[] data) {
        this.data = data;
    }

    private String client;
    private byte[] data;
}

The same situation in dart library, but not in swift

@FZambia
Copy link
Member

FZambia commented May 18, 2022

Hello @shalom-aviv

Thanks, yeah, I noticed this and fixed while working on #58 (code). But that PR changes lots of things and will land a bit later (part of centrifugal/centrifugo#500) – so for now we still need to support this field separately in current master.

Do you want to send PR supporting this? If not - I'll be able to add the missing field at some point (hopefully this week).

@shalom-aviv
Copy link
Contributor Author

Please review my changes in pull request:
#67

Thank you

@FZambia
Copy link
Member

FZambia commented May 19, 2022

Thanks! Just released 0.4.6

@FZambia FZambia closed this as completed May 19, 2022
@shalom-aviv
Copy link
Contributor Author

Awesome!
You are very speedy!
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants