Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate possible migration to github.com/go-redis/redis #210

Closed
FZambia opened this issue Oct 20, 2021 · 3 comments
Closed

Investigate possible migration to github.com/go-redis/redis #210

FZambia opened this issue Oct 20, 2021 · 3 comments

Comments

@FZambia
Copy link
Member

FZambia commented Oct 20, 2021

My initial quick measurements for asking stream top showed that we can get ~25% performance boost in Redis benchmarks if migrating from Redigo to github.com/go-redis/redis/v8. But this requires more effort to measure in various scenarios.

github.com/go-redis/redis also supports Redis Cluster and Sentinel so I believe we can migrate related parts too. The good thing is that those are supported by github.com/go-redis/redis natively while currently with redigo we are using 2 additional libs for this: github.com/mna/redisc and github.com/FZambia/sentinel.

Since we have pretty big Redis related code base we may want to migrate step-by-step.

@FZambia
Copy link
Member Author

FZambia commented Apr 7, 2022

Or to https://github.com/rueian/rueidis which seems great but need to check whether it fits well our use case (especially PUB/SUB part - we currently have nice re-subscription implementation, hope it's possible to replicate with rueidis).

@FZambia
Copy link
Member Author

FZambia commented Nov 28, 2022

Migrated to rueidis in #262 - next days I'll proceed with release and blog post about the migration. The draft of blog post is here: centrifugal/centrifugal.dev#18

@FZambia
Copy link
Member Author

FZambia commented Jan 20, 2023

v0.28.0 contains new Redis Engine implementation based on https://github.com/rueian/rueidis

@FZambia FZambia closed this as completed Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant