Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old issues from the JeffGarland version #10

Open
KingDuckZ opened this issue May 27, 2015 · 9 comments
Open

Old issues from the JeffGarland version #10

KingDuckZ opened this issue May 27, 2015 · 9 comments

Comments

@KingDuckZ
Copy link

Hello, I've kept visiting this project from time to time, I hope it's going to become a little bit more active since the fork. I'm especially interested in those two bugs:

JeffGarland/liaw2014#14
and
JeffGarland/liaw2014#15

Please don't forget about them!

@mjcaisse
Copy link
Member

Hello! Thank you for reminding me of these issues.

A lot more progress has been made on the library this month. I'm hopeful that we will get some time to wrap up most of Mustache features in the next few weeks.

@mjcaisse
Copy link
Member

KingDuckZ -

Are you using C++11/14?

@KingDuckZ
Copy link
Author

Hi, thanks for trying to support me :) Yes, I use c++11, but I'm ok with using any newer standard that is available in my compiler.
Either gcc 4.8.4 or clang 3.5.0 are fine, so whatever they support is fine with me. If it's really necessary I can try to upgrade them.

@KingDuckZ
Copy link
Author

Any clue on wether you'll be able to fix those?

@mjcaisse
Copy link
Member

Hi KingDuckZ -

I'll be working on the library again in a couple weeks. Sorry about the delay. Both of these older issues will be resolved. Thank you for your patience and interest.

@KingDuckZ
Copy link
Author

Hi mjcaisse, did you get to work on those old issues yet?

@mjcaisse
Copy link
Member

I made a change last week (pushed to develop) to address JeffGarland/liaw2014#15 , "Empty lines get added while iterating over values #15"; however, I think it is incorrect after looking at some results.

I've just found the "spec" (go figure ... there is a spec). Unfortunately, it isn't very clear on whitespace. I'll be updating the implementation based on the contents of https://github.com/mustache/spec.

@KingDuckZ
Copy link
Author

I don't know about specs really... to me the mustache page looks like "this is what the output of the sample input should look like". I'd say if a line only contains a {{#tag}} then remove the next \n, otherwise don't do it. I've been trying the ruby implementation and I think that's what it does. (btw even the ruby implementation doesn't do what I need, I had to do horrible hacks to make it behave as I wanted to - I think boostache is the only implementation that lets you treat tags like function calls out of the box)

KingDuckZ pushed a commit to KingDuckZ/boostache that referenced this issue Sep 8, 2015
@mjcaisse
Copy link
Member

Old issue 15 resolved with 5e8d606.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants