-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension does not respect custom uploader implementations #16
Comments
cc @brew in case you ever bump into this |
So what I did here is basically getting route's controller and overriding it's method by wrapping it into decorator. |
#28 merged into master. |
Is there any more recent activity on this? Not sure if its something on my end or not, but downloads to s3filestore are not working properly on my instance with CKAN 2.9.5 and s3filestore and googleanalytics extensions. I've tried flipping the order of the plugins and the downloads return an error both times. Uninstalling ckanext-googleanalytics resolves the issue. |
I think, there was a config option, which should handle the problem.
|
ckanext--s3filestore implements a custom uploader and downloader, overriding the core download endpoint. ckanext-googleanalytics does the same, to register the download and calls the core download action from the package controller afterwards.
So if you load the
googleanalytics
before thes3filestore
one, your downloads return 404, because the core filesystem filestore is being called:Loading
googleanalytics
last works:The text was updated successfully, but these errors were encountered: