Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image in beginning of reply is incorrectly ignored #22

Open
thomasst opened this issue Jun 7, 2018 · 2 comments · May be fixed by #26
Open

Image in beginning of reply is incorrectly ignored #22

thomasst opened this issue Jun 7, 2018 · 2 comments · May be fixed by #26
Labels
bug

Comments

@thomasst
Copy link
Member

thomasst commented Jun 7, 2018

It should be part of html.

In [4]: quotequail.unwrap_html("Test 2.<br><br>On Jun 05, 2018, at 09:56 AM, John Doe &lt;john@example.com&gt; wrote:<br><blockquote><img src=\"https://example.com\" class=\"fr-fic fr-dib\"><br>Some text 1.<br><br>Bart</blockquote>")
Out[4]: 
{'date': 'Jun 05, 2018, at 09:56 AM',
 'from': 'John Doe <john@example.com>',
 'html': u'<div>Some text 1.<br><br>Bart</div>',
 'html_top': u'Test 2.',
 'type': 'reply'}
@thomasst thomasst added the bug label Jun 7, 2018
@thomasst thomasst mentioned this issue Jun 7, 2018
Open
@andreip andreip linked a pull request Jul 5, 2018 that will close this issue
Open
@afzalIbnSH
Copy link

Any progress here? Can #26 be merged?

@afzalIbnSH
Copy link

I tested the PR in my project and it works nicely. Would be great if it can be merged. @wojcikstefan

@afzalIbnSH afzalIbnSH mentioned this issue Sep 16, 2021
Merged
afzalIbnSH added a commit to freightwalla/quotequail that referenced this issue Sep 16, 2021
@afzalIbnSH
Don't ignore images (#2)
d26bd16 
Image in beginning of reply is incorrectly ignored. Fix.

Originally reported in closeio#22 and solved by @andreip in closeio#26

In his words:
"Couldn't think of a different approach, since an img isn't really a block, so it'll never have a text within it, so no point in generating a different html in get_line_info functions. Instead, what was missing was it being treated as a special case: don't want to slice a line from the HTML by just looking at the plain text lines, since that could slice an img, need to also look at the start/end refs for replaced tags.

See more about a replaced element (https://developer.mozilla.org/en-US/docs/Web/CSS/Replaced_element). I think it might be worth adding a few more things to the list? e.g. video, embed etc. ; not sure about iframe and how that'd be treated in lxml parsing though, but I suppose you could have an iframe with just an image in it, in which case you'd still want to keep it?

Full list would be a total of 9 replaced elements (or 10 if we also count input; although I'm not sure of all examples where that'd generate sth even if it apparently has no text in it)."
@afzalIbnSH afzalIbnSH mentioned this issue Sep 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add img to replaced tags which get preserved in HTML from slicing. andreip/quotequail
2 participants
@thomasst @afzalIbnSH