Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cl-image ignores a cl-transformation if it has an ng-if #105

Open
dorongutman opened this issue Sep 15, 2017 · 5 comments
Open

cl-image ignores a cl-transformation if it has an ng-if #105

dorongutman opened this issue Sep 15, 2017 · 5 comments
Assignees
@eitanp461
Labels
bug

Comments

@dorongutman
Copy link

I have the following code:
https://plnkr.co/edit/tZdVOELNOVRw9zhCa4M1?p=preview

  1. You can see that the first line of photos that ng-if on the <cl-image> tag works fine - when true the image is shown, when false the image isn't showing.
  2. In the second line of photos, the ng-if condition is completely ignored - both in the case of true and in false the transformation isn't applied.
@eitanp461
Copy link
Contributor

@dorongutman verifying by your example, you are referring to the AngularJS/Angular1 SDK, right?

@dorongutman
Copy link
Author

@eitanp461 that's correct.

@roeeba roeeba added the bug label Sep 18, 2017
YomesInc added a commit that referenced this issue Sep 18, 2017
@YomesInc
cl-image ignores a cl-transformation if it has an ng-if #105
c4a47a8 
-fixed bug
-corrected tests
@dorongutman
Copy link
Author

hey @eitanp461 any updates on this ?

@roeeba
Copy link
Collaborator

roeeba commented Oct 8, 2017

Hi @dorongutman, sorry for the delayed reply. Our team is still working on this. We will update as soon as this is resolved. Thank you for your patience.

shedar added a commit that referenced this issue Apr 10, 2018
@shedar
Fix cl-transformation support of ng-if (#105)
1262a40
@skelesp
Copy link

skelesp commented Oct 4, 2018

Why isn't this merged in 1.x branch?

shedar added a commit that referenced this issue Mar 12, 2019
@shedar
Fix cl-transformation support of ng-if (#105)
3dd6b62
tocker pushed a commit that referenced this issue Mar 12, 2019
@shedar
Fix cl-transformation support of ng-if (#105)
bbc8002
tocker pushed a commit that referenced this issue Mar 12, 2019
@shedar @tocker
Fix cl-transformation support of ng-if (#105) (#146)
076f66f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eitanp461 eitanp461

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dorongutman @eitanp461 @roeeba @skelesp