From af4000fa25d0e93f75bce8284b25cb29b06f1861 Mon Sep 17 00:00:00 2001 From: "yuxuan.wang1" Date: Thu, 10 Oct 2024 16:14:28 +0800 Subject: [PATCH] add comment and remove redundant statement --- pkg/streamx/provider/ttstream/stream.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/pkg/streamx/provider/ttstream/stream.go b/pkg/streamx/provider/ttstream/stream.go index 3e04d8a4dd..c6196e26a2 100644 --- a/pkg/streamx/provider/ttstream/stream.go +++ b/pkg/streamx/provider/ttstream/stream.go @@ -166,10 +166,11 @@ func (s *stream) readTrailerFrame(fr *Frame) (err error) { return fmt.Errorf("stream read a unexcept trailer") } + // when server-side returns non-biz error, it will be wrapped as ApplicationException stored in trailer frame payload if len(fr.payload) > 0 { _, _, ex := thrift.UnmarshalFastMsg(fr.payload, nil) s.err = ex.(*thrift.ApplicationException) - } else { + } else { // when server-side returns biz error, payload is empty and biz error information is stored in trailer frame header bizErr, err := transmeta.ParseBizStatusErr(fr.trailer) if err != nil { s.err = err @@ -207,9 +208,6 @@ func (s *stream) appendTrailer(kvs ...string) (err error) { if len(kvs)%2 != 0 { return fmt.Errorf("got the odd number of input kvs for Trailer: %d", len(kvs)) } - if s.wtrailer == nil { - s.wtrailer = make(streamx.Trailer) - } var key string for i, str := range kvs { if i%2 == 0 {