Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credentials and Parameters should have the same structure #279

Open
astrieanna opened this issue Sep 13, 2019 · 4 comments
Open

Credentials and Parameters should have the same structure #279

astrieanna opened this issue Sep 13, 2019 · 4 comments

Comments

@astrieanna
Copy link
Contributor

astrieanna commented Sep 13, 2019

Currently, credentials cannot have definitions and cannot apply to only some actions. Parameters can do both of these things.

Since the main difference between credentials and parameters is the semantic one (does the invocation image use the credentials or does the application-being-installed), I think these should be identical in structure in the bundle.

This would also impact stateless custom actions: they would no longer need to bypass the runtime checking for required credentials because the credentials could indicate what actions they apply to.

cc @youreddy

@carolynvs
Copy link
Contributor

I agree that if they are supposed to only be semantically different, it would really help if they had the same capabilities.

Also it's super annoying to have to specify credentials for actions that don't need them. 😀

@jeremyrickard
Copy link
Member

I'm super in favor of this, thanks for opening @astrieanna.

I think this introduces a question, we've made the spec 1.0. Does this necessitate a 1.1? Thoughts @technosophos? I'm happy to open a new milestone for 1.1 and we can start tracking things.

@technosophos
Copy link
Member

It would need a 1.1, which is fine with me. If it introduces backward compatibility breaks, it would need a 2.0, so I would prefer not to do that. But... judging by the description of what @astrieanna would like to change, I don't think we'll have any breaking changes.

@technosophos
Copy link
Member

This issue seems to be dead. Is anyone working on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants