Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken tests #44

Open
yukiisbored opened this issue Nov 24, 2017 · 7 comments
Open

Fix broken tests #44

yukiisbored opened this issue Nov 24, 2017 · 7 comments
Assignees

Comments

@yukiisbored
Copy link
Member

yukiisbored commented Nov 24, 2017

The tests are failing which is blocking PRs and further contributions to this project. A fix or temporary workaround is needed before GCI.

https://travis-ci.org/coala/coala-eclipse

@manankalra
Copy link

@yukiisbored I'm a newcomer and just opened a PR in this repo. Just wanted to know if there's any progress on this.

@yukiisbored
Copy link
Member Author

@manankalra Hey, very little progress is made due to time constraints. I'm gonna unassign myself from this.

@yukiisbored yukiisbored removed their assignment Dec 29, 2017
@manankalra
Copy link

manankalra commented Dec 29, 2017

@yukiisbored I can take this issue if you can guide me a little on what needs to be done. :)

@saksham189
Copy link

I want to try and fix this... can you assign this to me? @yukiisbored

@jayvdb
Copy link
Member

jayvdb commented Jun 17, 2018

#51 is likely to be helpful to find and fix this bug.

@jayvdb
Copy link
Member

jayvdb commented Jun 20, 2018

Current log of the test failure
https://travis-ci.org/coala/coala-eclipse/builds/394379974

@saksham189
Copy link

saksham189 commented Jun 20, 2018

The RunCmdTest is throwing error:

Running com.coala.core.tests.RunCmdTest while calling 
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 3.011 sec <<< FAILURE! - in com.coala.core.tests.RunCmdTest
test(com.coala.core.tests.RunCmdTest)  Time elapsed: 3.011 sec  <<< ERROR!
org.apache.commons.exec.ExecuteException: Process exited with an error: 255 (Exit value: 255)
	at org.apache.commons.exec.DefaultExecutor.executeInternal(DefaultExecutor.java:404)
	at org.apache.commons.exec.DefaultExecutor.execute(DefaultExecutor.java:166)
	at org.apache.commons.exec.DefaultExecutor.execute(DefaultExecutor.java:153)
	at com.coala.core.utils.ExternalUtils.getAvailableBears(ExternalUtils.java:188)
	at com.coala.core.utils.ExternalUtils.getBearSettings(ExternalUtils.java:195)
	at com.coala.core.utils.ExternalUtils.runBearOnFile(ExternalUtils.java:55)
	at com.coala.core.tests.RunCmdTest.test(RunCmdTest.java:58)

The getAvailableBears method shown below runs coala -B --json which must be throwing error because of this issue: coala/coala#4881

public static JSONArray getAvailableBears() throws ExecuteException, IOException {
    CommandLine cmdLine = new CommandLine("coala");
    cmdLine.addArgument("--json");
    cmdLine.addArgument("-B");
    final ByteArrayOutputStream stdout = new ByteArrayOutputStream();
    PumpStreamHandler pumpStreamHandler = new PumpStreamHandler(stdout, null);
    Executor executor = new DefaultExecutor();
    executor.setStreamHandler(pumpStreamHandler);
    executor.execute(cmdLine);
    JSONArray bearList = new JSONObject(stdout.toString()).getJSONArray("bears");
    return bearList;
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants