Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deselect star when user attempts to favorite without notification permissions allowed #26

Open
peterkos opened this issue May 25, 2020 · 0 comments
Open

Deselect star when user attempts to favorite without notification permissions allowed #26

peterkos opened this issue May 25, 2020 · 0 comments
Labels
good first issue Good for newcomers improvement Not features, but small touchups.

Comments

@peterkos
Copy link
Contributor

Currently, when the user attempts to favorite an event, and doesn't have notifications enabled, a nice popup comes up and explains this situation.
However, on dismiss, the user's selection is still visible. This should be fixed so the user is aware that the action has not yet been completed, and the need to enable notification permissions!
@peterkos peterkos added improvement Not features, but small touchups. good first issue Good for newcomers labels May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers improvement Not features, but small touchups.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peterkos