Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests to jest #1136

Open
NothingEverHappens opened this issue Oct 8, 2019 · 7 comments
Open

Move tests to jest #1136

NothingEverHappens opened this issue Oct 8, 2019 · 7 comments

Comments

@NothingEverHappens
Copy link
Collaborator

NothingEverHappens commented Oct 8, 2019

What the issue is about

Right now we're using karma for some tests and jest for the other ones.
Jest is faster, so we should set up all our tests to use it

Where to start

We're using nx, check out their docs for moving to jest
Search for test in package json to see how we run tests now

@hansal7014
Copy link

Hi,
Please can I work on this issue?
Thanks.

@kirjs
Copy link
Collaborator

kirjs commented Oct 19, 2019

@hansal7014 Go for it, let me know if you get stack at any point,

cc @matt-oconnell who was looking into fixing test, just FYI

@hansal7014
Copy link

@kirjs There are about 50 test files using karma (i.e. with extension '.spec.ts'). Do all of them need to be converted to use Jest? If so, I would like to break up the work app-wise given the large number of tests.

@NothingEverHappens
Copy link
Collaborator Author

Yes, all apps should use jest in the end.
Breaking the work up per-app would make sense to me.

Also note that some tests are still broken, fixing them doesn't have to be part of this task

@kirjs
Copy link
Collaborator

kirjs commented Oct 22, 2019

hey @hansal7014 there was some work done with this in #1176, not sure what your status is on this, just trying to avoid further redundant work

@hansal7014
Copy link

Hi @kirjs,
Looks like I worked on some tests which are already done in #1176. @Mutmatt, can you tell me if there are any tests remaining which need to be refactored to use Jest.

@O-Mutt
Copy link
Contributor

O-Mutt commented Oct 23, 2019

Hi @kirjs,
Looks like I worked on some tests which are already done in #1176. @Mutmatt, can you tell me if there are any tests remaining which need to be refactored to use Jest.

I primarily tried to get kirjs's tests running and functional. If you look at any other project the tests may be less functional. All of the tests should now be running under the jest framework, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants