-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tests to jest #1136
Comments
Hi, |
@hansal7014 Go for it, let me know if you get stack at any point, cc @matt-oconnell who was looking into fixing test, just FYI |
@kirjs There are about 50 test files using karma (i.e. with extension '.spec.ts'). Do all of them need to be converted to use Jest? If so, I would like to break up the work app-wise given the large number of tests. |
Yes, all apps should use jest in the end. Also note that some tests are still broken, fixing them doesn't have to be part of this task |
hey @hansal7014 there was some work done with this in #1176, not sure what your status is on this, just trying to avoid further redundant work |
I primarily tried to get kirjs's tests running and functional. If you look at any other project the tests may be less functional. All of the tests should now be running under the jest framework, though. |
What the issue is about
Right now we're using karma for some tests and jest for the other ones.
Jest is faster, so we should set up all our tests to use it
Where to start
We're using nx, check out their docs for moving to jest
Search for
test
in package json to see how we run tests nowThe text was updated successfully, but these errors were encountered: