Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress files in a single queue, not by directory #16

Open
aidanheerdegen opened this issue Aug 6, 2019 · 0 comments
Open

Compress files in a single queue, not by directory #16

aidanheerdegen opened this issue Aug 6, 2019 · 0 comments

Comments

@aidanheerdegen
Copy link
Member

The original decision to compress files by directory is flawed. It limits parallelisation to the number of files in a directory, and also means directory traversal and file identification cannot occur in parallel with file compression.

Would be much better, and cleaner, to have a single queue for files to compress and have a thread which finds files to compress and adds them to the queue.

One of the reasons for the original design was so nccompress could clean up after itself, and remove the tmpdir, and complain if it couldn't, which indicated a problem compressing a file. This was stupid. There are other ways to achieve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant