From 625cc40c9bb10dfc06d957966fc876b0c833e9c1 Mon Sep 17 00:00:00 2001
From: gleizesDor <115622893+gleizesDor@users.noreply.github.com>
Date: Thu, 21 Mar 2024 13:49:31 +0100
Subject: [PATCH] feat(#375): Update to Java 21

Signed-off-by: gleizesDor <115622893+gleizesDor@users.noreply.github.com>
---
 .github/workflows/automate_javadoc.yml    |  4 +-
 .github/workflows/build-project.yml       |  4 +-
 .github/workflows/release-project.yml     |  4 +-
 .github/workflows/sonarcloud-analysis.yml |  4 +-
 .github/workflows/sonarcloud-build.yml    |  4 +-
 docs/examples/example-app/pom.xml         |  6 +-
 pom.xml                                   | 76 +++++++++++++++--------
 sct-app/pom.xml                           | 13 ++--
 sct-commons/pom.xml                       | 11 ++--
 sct-coverage/pom.xml                      |  2 +-
 10 files changed, 80 insertions(+), 48 deletions(-)

diff --git a/.github/workflows/automate_javadoc.yml b/.github/workflows/automate_javadoc.yml
index a9756bdb0..9372ad0e8 100644
--- a/.github/workflows/automate_javadoc.yml
+++ b/.github/workflows/automate_javadoc.yml
@@ -19,11 +19,11 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v4
 
-      - name: Set up JDK 17
+      - name: Set up JDK 21
         uses: actions/setup-java@v4
         with:
           distribution: 'zulu'
-          java-version: '17'
+          java-version: '21'
 
       - name: Create custom Maven Settings.xml
         uses: whelk-io/maven-settings-xml-action@v21
diff --git a/.github/workflows/build-project.yml b/.github/workflows/build-project.yml
index 7ca1b9905..ec62507b2 100644
--- a/.github/workflows/build-project.yml
+++ b/.github/workflows/build-project.yml
@@ -23,11 +23,11 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v4
 
-      - name: Set up JDK 17
+      - name: Set up JDK 21
         uses: actions/setup-java@v4
         with:
           distribution: 'zulu'
-          java-version: '17'
+          java-version: '21'
 
       - name: Create custom Maven Settings.xml
         uses: whelk-io/maven-settings-xml-action@v21
diff --git a/.github/workflows/release-project.yml b/.github/workflows/release-project.yml
index 20c9b7eee..f044f3d02 100644
--- a/.github/workflows/release-project.yml
+++ b/.github/workflows/release-project.yml
@@ -18,11 +18,11 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v4
 
-      - name: Set up JDK 17
+      - name: Set up JDK 21
         uses: actions/setup-java@v4
         with:
           distribution: 'zulu'
-          java-version: '17'
+          java-version: '21'
 
       - name: Create custom Maven Settings.xml
         uses: whelk-io/maven-settings-xml-action@v21
diff --git a/.github/workflows/sonarcloud-analysis.yml b/.github/workflows/sonarcloud-analysis.yml
index 4641ae4a5..da100bc1a 100644
--- a/.github/workflows/sonarcloud-analysis.yml
+++ b/.github/workflows/sonarcloud-analysis.yml
@@ -61,11 +61,11 @@ jobs:
         key: ${{ runner.os }}-sonar
         restore-keys: ${{ runner.os }}-sonar
 
-    - name: Set up JDK 17
+    - name: Set up JDK 21
       uses: actions/setup-java@v4
       with:
         distribution: 'zulu'
-        java-version: '17'
+        java-version: '21'
         cache: 'maven'
 
     - name: Set Common Sonar Variables
diff --git a/.github/workflows/sonarcloud-build.yml b/.github/workflows/sonarcloud-build.yml
index c71626f92..5c389fa42 100644
--- a/.github/workflows/sonarcloud-build.yml
+++ b/.github/workflows/sonarcloud-build.yml
@@ -26,11 +26,11 @@ jobs:
           key: ${{ runner.os }}-sonar
           restore-keys: ${{ runner.os }}-sonar
 
-      - name: Set up JDK 17
+      - name: Set up JDK 21
         uses: actions/setup-java@v4
         with:
           distribution: 'zulu'
-          java-version: '17'
+          java-version: '21'
           cache: 'maven'
 
       - name: Create custom Maven Settings.xml
diff --git a/docs/examples/example-app/pom.xml b/docs/examples/example-app/pom.xml
index d255c6df7..664c35c27 100644
--- a/docs/examples/example-app/pom.xml
+++ b/docs/examples/example-app/pom.xml
@@ -18,9 +18,9 @@ SPDX-License-Identifier: Apache-2.0
 
   <properties>
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-    <maven.compiler.source>17</maven.compiler.source>
-    <maven.compiler.target>17</maven.compiler.target>
-    <maven.compiler.release>17</maven.compiler.release>
+    <maven.compiler.source>21</maven.compiler.source>
+    <maven.compiler.target>21</maven.compiler.target>
+    <maven.compiler.release>21</maven.compiler.release>
   </properties>
 
   <distributionManagement>
diff --git a/pom.xml b/pom.xml
index 150a6b15a..97a37d1d8 100644
--- a/pom.xml
+++ b/pom.xml
@@ -29,21 +29,31 @@
     </repositories>
 
     <properties>
-        <java.version>17</java.version>
-        <maven.compiler.target>${java.version}</maven.compiler.target>
-        <maven.compiler.source>${java.version}</maven.compiler.source>
+        <java.version>21</java.version>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-        <sonar.coverage.exclusions>sct-coverage/**</sonar.coverage.exclusions>
-        <aggregate.report.dir>../sct-coverage/target/site/jacoco-aggregate/jacoco.xml</aggregate.report.dir>
-        <sonar.coverage.jacoco.xmlReportPaths>${basedir}/${aggregate.report.dir}</sonar.coverage.jacoco.xmlReportPaths>
+
+        <!-- jacoco est utilisé par sonar pour afficher le rapport de couverture des tests -->
+        <jacoco-maven-plugin.version>0.8.11</jacoco-maven-plugin.version>
+
+        <!-- compas -->
         <compas-core.version>0.19.0</compas-core.version>
         <compas-scl-xsd.version>0.0.4</compas-scl-xsd.version>
-        <maven.plugin.javadoc>3.4.1</maven.plugin.javadoc>
-        <maven-source-plugin.version>3.2.1</maven-source-plugin.version>
+
+        <!-- maven -->
+        <maven-surefire-plugin.version>3.2.5</maven-surefire-plugin.version>
+        <maven-javadoc-plugin.version>3.6.3</maven-javadoc-plugin.version>
+        <maven-source-plugin.version>3.3.0</maven-source-plugin.version>
+        <maven-jar-plugin.version>3.3.0</maven-jar-plugin.version>
+        <maven-compiler-plugin.version>3.13.0</maven-compiler-plugin.version>
+        <maven-dependency-plugin.version>3.6.1</maven-dependency-plugin.version>
+
+        <jaxb2-maven-plugin.version>3.1.0</jaxb2-maven-plugin.version>
+
         <junit-version>5.9.0</junit-version>
         <logback-classic.version>1.4.5</logback-classic.version>
         <assertj.version>3.22.0</assertj.version>
-        <lombok.version>1.18.24</lombok.version>
+        <!-- lombok est compatible jdk21 à partir de la 18.30-->
+        <lombok.version>1.18.30</lombok.version>
         <mockito.version>5.5.0</mockito.version>
         <jackson-databind.version>2.13.4.1</jackson-databind.version>
     </properties>
@@ -130,37 +140,31 @@
                 <plugin>
                     <groupId>org.apache.maven.plugins</groupId>
                     <artifactId>maven-compiler-plugin</artifactId>
-                    <version>3.10.1</version>
+                    <version>${maven-compiler-plugin.version}</version>
                     <configuration>
                         <source>${java.version}</source>
                         <target>${java.version}</target>
-                        <compilerArgs>--enable-preview</compilerArgs>
                     </configuration>
                 </plugin>
-                <plugin>
-                    <groupId>org.jacoco</groupId>
-                    <artifactId>jacoco-maven-plugin</artifactId>
-                    <version>0.8.8</version>
-                </plugin>
                 <plugin>
                     <groupId>org.apache.maven.plugins</groupId>
                     <artifactId>maven-surefire-plugin</artifactId>
-                    <version>2.22.2</version>
-                    <configuration>
-                        <!--keep the existing values using @{argLine} syntax-->
-                        <!-- https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#argLine -->
-                        <argLine>@{argLine} --enable-preview</argLine>
-                    </configuration>
+                    <version>${maven-surefire-plugin.version}</version>
                 </plugin>
                 <plugin>
                     <groupId>org.apache.maven.plugins</groupId>
                     <artifactId>maven-jar-plugin</artifactId>
-                    <version>3.2.2</version>
+                    <version>${maven-jar-plugin.version}</version>
+                </plugin>
+                <plugin>
+                    <groupId>org.apache.maven.plugins</groupId>
+                    <artifactId>maven-dependency-plugin</artifactId>
+                    <version>${maven-dependency-plugin.version}</version>
                 </plugin>
                 <plugin>
                     <groupId>org.apache.maven.plugins</groupId>
                     <artifactId>maven-javadoc-plugin</artifactId>
-                    <version>${maven.plugin.javadoc}</version>
+                    <version>${maven-javadoc-plugin.version}</version>
                     <executions>
                         <execution>
                             <id>attach-javadocs</id>
@@ -185,6 +189,16 @@
                         </execution>
                     </executions>
                 </plugin>
+                <plugin>
+                    <groupId>org.jacoco</groupId>
+                    <artifactId>jacoco-maven-plugin</artifactId>
+                    <version>${jacoco-maven-plugin.version}</version>
+                </plugin>
+                <plugin>
+                    <groupId>org.codehaus.mojo</groupId>
+                    <artifactId>jaxb2-maven-plugin</artifactId>
+                    <version>${jaxb2-maven-plugin.version}</version>
+                </plugin>
             </plugins>
         </pluginManagement>
 
@@ -194,11 +208,23 @@
                 <artifactId>jacoco-maven-plugin</artifactId>
                 <executions>
                     <execution>
-                        <id>prepare-agent</id>
+                        <id>pre-unit-tests</id>
                         <goals>
                             <goal>prepare-agent</goal>
                         </goals>
                     </execution>
+                    <execution>
+                        <id>post-unit-test</id>
+                        <phase>test</phase>
+                        <goals>
+                            <goal>report</goal>
+                        </goals>
+                        <configuration>
+                            <formats>
+                                <format>XML</format>
+                            </formats>
+                        </configuration>
+                    </execution>
                 </executions>
             </plugin>
         </plugins>
diff --git a/sct-app/pom.xml b/sct-app/pom.xml
index 23cd3d5a7..2edf11adc 100644
--- a/sct-app/pom.xml
+++ b/sct-app/pom.xml
@@ -17,10 +17,6 @@
     <version>local-SNAPSHOT</version>
     <name>SCT-APP</name>
 
-    <properties>
-        <sonar.coverage.jacoco.xmlReportPaths>${basedir}/${aggregate.report.dir}</sonar.coverage.jacoco.xmlReportPaths>
-    </properties>
-
     <dependencies>
         <dependency>
             <groupId>org.lfenergy.compas</groupId>
@@ -62,6 +58,7 @@
             <artifactId>mockito-junit-jupiter</artifactId>
         </dependency>
     </dependencies>
+
     <build>
         <plugins>
             <plugin>
@@ -88,13 +85,19 @@
                         <goals>
                             <goal>report</goal>
                         </goals>
+                        <!-- la rapport est généré par défaut: target/site/jacoco/jacoco.xml -->
+                        <configuration>
+                            <formats>
+                                <!-- sonar a uniquement besoin du xml -->
+                                <format>XML</format>
+                            </formats>
+                        </configuration>
                     </execution>
                 </executions>
             </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-dependency-plugin</artifactId>
-                <version>3.3.0</version>
                 <executions>
                     <execution>
                         <id>unpack</id>
diff --git a/sct-commons/pom.xml b/sct-commons/pom.xml
index 285b507b1..a7e978f7a 100644
--- a/sct-commons/pom.xml
+++ b/sct-commons/pom.xml
@@ -18,8 +18,6 @@
     <name>SCT-COMMONS</name>
 
     <properties>
-        <sonar.coverage.jacoco.xmlReportPaths>${basedir}/${aggregate.report.dir}</sonar.coverage.jacoco.xmlReportPaths>
-        <sonar.jacoco.excludes>**/scl2007b4/**/*</sonar.jacoco.excludes>
         <opencsv.version>5.7.1</opencsv.version>
         <jakarta.xml.bind-api.version>4.0.0</jakarta.xml.bind-api.version>
         <jaxb-runtime.version>4.0.3</jaxb-runtime.version>
@@ -124,13 +122,19 @@
                         <goals>
                             <goal>report</goal>
                         </goals>
+                        <!-- la rapport est généré par défaut: target/site/jacoco/jacoco.xml -->
+                        <configuration>
+                            <formats>
+                                <!-- sonar a uniquement besoin du xml -->
+                                <format>XML</format>
+                            </formats>
+                        </configuration>
                     </execution>
                 </executions>
             </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-dependency-plugin</artifactId>
-                <version>3.3.0</version>
                 <executions>
                     <execution>
                         <id>unpack</id>
@@ -158,7 +162,6 @@
             <plugin>
                 <groupId>org.codehaus.mojo</groupId>
                 <artifactId>jaxb2-maven-plugin</artifactId>
-                <version>3.1.0</version>
                 <executions>
                     <execution>
                         <id>scl</id>
diff --git a/sct-coverage/pom.xml b/sct-coverage/pom.xml
index 95f98614e..ca1d14717 100644
--- a/sct-coverage/pom.xml
+++ b/sct-coverage/pom.xml
@@ -21,8 +21,8 @@
     <properties>
         <maven.deploy.skip>true</maven.deploy.skip>
         <maven.javadoc.skip>true</maven.javadoc.skip>
-        <sonar.jacoco.excludes>**/scl2007b4/**/*</sonar.jacoco.excludes>
     </properties>
+
     <dependencies>
         <dependency>
             <groupId>org.lfenergy.compas</groupId>