-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up package installation #329
Comments
base_setup.sh cleanup: #330 |
I think the best way to approach this is to first refactor the build such that it goes: setup agnos-compiler -> compile all the things -> assemble final image. Right now it's all jumbled up, and once we fix that, it'll become more clear how to clean this up. |
How about moving out the compilation into a separate dockerfile and provide the compiled debs and whls to the main docker build? |
@adeebshihadeh I moved the package installation to a separate docker file that is build before the main one. #354 |
I moved the compilation to the top of the main dockerfile instead: #354 |
The apt package installation parts of the agnos build are currently not very well maintained. Lets discuss here how to improve this.
Currently existing:
What should be included (open for discussion):
base_setup.sh
openpilot_dependencies.sh
hardware_setup.sh
install_extras.sh
The text was updated successfully, but these errors were encountered: