Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up package installation #329

Open
robin-reckmann opened this issue Aug 30, 2024 · 5 comments
Open

Clean up package installation #329

robin-reckmann opened this issue Aug 30, 2024 · 5 comments
Labels

Comments

@robin-reckmann
Copy link
Contributor

The apt package installation parts of the agnos build are currently not very well maintained. Lets discuss here how to improve this.

Currently existing:

base_setup.sh
openpilot_dependencies.sh
hardware_setup.sh
install_extras.sh

What should be included (open for discussion):

base_setup.sh

  • Anything that is needed to boot into a minimal system with network connectivity

openpilot_dependencies.sh

  • Any libraries or tools that OP requires (ideally this should be maintained within OP repo)

hardware_setup.sh

  • Not clear, maybe merge with base setup?

install_extras.sh

  • Any additional tooling that is nice to have but not necessary for OP operation.
  • Could we excluded from the standard agnos image and pulled in if necessary
@robin-reckmann
Copy link
Contributor Author

base_setup.sh cleanup: #330

@adeebshihadeh
Copy link
Contributor

adeebshihadeh commented Sep 2, 2024

I think the best way to approach this is to first refactor the build such that it goes: setup agnos-compiler -> compile all the things -> assemble final image. Right now it's all jumbled up, and once we fix that, it'll become more clear how to clean this up.

@adeebshihadeh adeebshihadeh added this to the agnos 11 milestone Sep 2, 2024
@andiradulescu andiradulescu mentioned this issue Sep 3, 2024
@robin-reckmann
Copy link
Contributor Author

I think the best way to approach this is to first refactor the build such that it goes: setup agnos-compiler -> compile all the things -> assemble final image. Right now it's all jumbled up, and once we fix that, it'll become more clear how to clean this up.

How about moving out the compilation into a separate dockerfile and provide the compiled debs and whls to the main docker build?

@robin-reckmann
Copy link
Contributor Author

@adeebshihadeh I moved the package installation to a separate docker file that is build before the main one. #354

@robin-reckmann
Copy link
Contributor Author

I moved the compilation to the top of the main dockerfile instead: #354

@adeebshihadeh adeebshihadeh removed this from the agnos 11 milestone Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants