Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to Gift Aid batch timing out #64

Open
deepak-srivastava opened this issue Jan 2, 2019 · 1 comment · May be fixed by #65
Open

Add to Gift Aid batch timing out #64

deepak-srivastava opened this issue Jan 2, 2019 · 1 comment · May be fixed by #65

Comments

@deepak-srivastava
Copy link

deepak-srivastava commented Jan 2, 2019

Add to Gift Aid batch starts timing out for contributions greater than 3500. Some of our clients got contributions in the range 5k - 14k per month, where it really fails to respond.
On investigation we found that it's in fact the validation process which is timing out.

About to do a PR which converts the validation process into civi queue process, with a progress bar.

@artfulrobot
Copy link

Nb. the code that does this is very inefficient, which is probably causing this problem. For every contribution it loads (or reloads in the case of multiple contributions for a given contact) all the declarations for the contact, then php ambles through them one by one seeing if it can find a match. This could all be done much more efficiently with SQL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants