Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more extensive test suite #5

Open
h-vetinari opened this issue Dec 12, 2020 · 4 comments
Open

Use more extensive test suite #5

h-vetinari opened this issue Dec 12, 2020 · 4 comments
Assignees

Comments

@h-vetinari
Copy link
Member

Only testing the import of the python packages is not optimal. We should be using as much of the upstream test suite as possible in our CI (and with a timeout of 6h, we have ample time for testing). After a quick search upstream, these are things that are probably relevant:

CC @vnlitvinov

@krfricke
Copy link
Contributor

I agree with testing Ray core functionality by running some of the unit tests.

Here is our current Travis pipeline. The following three suites (Streaming, Worker, Tests) should be sufficient and run in ~20 minutes total. We could also opt to run ASAN tests (adding another 30 minutes).

https://github.com/ray-project/ray/blob/master/.buildkite/pipeline.yml#L102-L121

We can also find a (small) subset of sub library tests (for Ray Tune, Serve, RLLib) to run. In my opinion a very narrow set of basic functionality should suffice, as it should generally just serve as a smoke test to decide if the build succeeded and the sub libraries can actually be used at all. For this we will probably add another tag to the bazel rcs in upstream ray to be able to filter these.

@vnlitvinov
Copy link
Contributor

I think we should be good with running some smoke tests, as we take already tested Ray sources for the start.
So we just want to make sure that we didn't screw something up in patching and packaging, thus a bit of everything that pokes most binaries but runs fast is a good thing to get.

This would also benefit the core developers, as it would allow running smoke tests during development...

@h-vetinari
Copy link
Member Author

I don't know how long the full test suite for all things would run, but I prefer to be more comprehensive than just smoke tests, because various corner cases are often only caught by a handful of tests. I'd be fine if running the test suite adds an hour or a bit more to our CI.

@h-vetinari
Copy link
Member Author

@krfricke
Hope you don't mind, I took the liberty of assigning you to this issue. 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants