Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: let specific Client unmarshall its response #3

Open
donatorsky opened this issue May 20, 2022 · 0 comments
Open

Feature: let specific Client unmarshall its response #3

donatorsky opened this issue May 20, 2022 · 0 comments

Comments

@donatorsky
Copy link
Contributor

Feature description

Currently, Clients for specific ES versions handle their requests, but the destination handles their responses:
https://github.com/miquido/conduit-connector-elasticsearch/blob/feat/destination-connector/destination/destination.go#L340-L357

This logic needs to be rewritten to ensure that any future ES versions' changes can be handled and responses will be properly processed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant