Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failing to start sidecar gets real noisy in sentry #288

Open
jlrobins opened this issue Sep 24, 2024 · 0 comments
Open

failing to start sidecar gets real noisy in sentry #288

jlrobins opened this issue Sep 24, 2024 · 0 comments
Assignees
Labels
bug Something isn't working fromsentry Noticed from sentry exceptions triaged Team has initially triaged the issue

Comments

@jlrobins
Copy link
Contributor

throw new Error(getHandlePromise(${callnum}): failed to start sidecar);

when it happens the first time for user, for whatever / currently unknown reason, will end up happening A LOT.

Add a latch in sidecarManager.ts that gets set when this happens the first time, to then prevent even trying to start sidecar (until extension reset / restart).

@jlrobins jlrobins added bug Something isn't working triaged Team has initially triaged the issue fromsentry Noticed from sentry exceptions labels Sep 24, 2024
@jlrobins jlrobins self-assigned this Sep 24, 2024
@rhauch rhauch added this to the Telemetry improvements milestone Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fromsentry Noticed from sentry exceptions triaged Team has initially triaged the issue
Projects
None yet
Development

No branches or pull requests

2 participants