Feedback

[TomasTomecek]

Can we rename init to post-init and update the logic?

contained shell scripts (`*.sh`) are sourced when `service` is started

that doesn't make much sense, there is just before and after, not when.

Tests are missing (which is okay), we should just track it.

So, overall, I really like it. Obviously there is plenty of room to polish (make it more generic and get rid of specifics). Well done!

[LorbusChris]

I like this approach, too.
It seems very flexible and one can still mount config volumes in the container, overriding built in settings.

Just to be clear though, the implication is that running the container with non-default config requires s2i to be present on the host, right? Or does it require s2i even when not changing defaults?

Would be great to reach a consesus here and then get this into the template asap.

[rpitonak]

@LorbusChris
The s2i needs to be installed on the host only if you want to build the new image with non-default configuration. The result of command s2i build is new reproducible Docker image. So, s2i is not required for running any of the containers.

[TomasTomecek]

+1 to @rpitonak

our plan for configurable containerized services to be usable without any additional tooling: you can just docker run ... it, if you want to change configuration, you need s2i.