Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GPG signing since we're no longer deploying to Maven central? #318

Open
landonreed opened this issue May 11, 2021 · 0 comments
Open
Labels

Comments

@landonreed
Copy link
Contributor

I (and @br648) have noticed errors when running mvn package locally with gpg signing. Since we're deploying gtfs-lib to jitpack, I'm wondering if this plugin is still needed?

gtfs-lib/pom.xml

Lines 126 to 140 in a9eb787

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-gpg-plugin</artifactId>
<version>1.6</version>
<executions>
<execution>
<id>sign-artifacts</id>
<!-- We sign in the verify phase, which means it will happen for install and deploy but not package. -->
<phase>verify</phase>
<goals>
<goal>sign</goal>
</goals>
</execution>
</executions>
</plugin>

@landonreed landonreed added the bug label May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant