-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
what is the difference between dasd and metal4k on s390x? #3766
Comments
I think you're right. The most likely scenario is that when I opened #1130 way back when, I was focused on the x86_64 case and didn't realize that in the s390x case, it duplicated with the dasd format we had already learned to output. Ideally we could remove A safer approach we could do now is to just treat |
👍
Yeah. Maybe we should open a card for this and have someone investigate. The ultimate goal here is to simplify things and dropping whole artifacts is a big win IMO.
I'm actually OK shipping it as is for now if we can take steps towards the longer term goal of removing it. I was investigating this for OSBuild purposes and the answer for now is pretty much to just copy the metal4k disk image output to a new dasd output stage. It's just a reflink copy so shouldn't hurt in the pipeline. |
I guess |
Also thanks to usage of |
Are you saying that absolutely nothing uses it today? |
I think it'd be hard to rule that out entirely. It's on the mirrors, so anyone could be downloading that image and plugging it into their install flow. I can certainly imagine people being confused and picking the dasd image over the metal4k one because it's more specific to what they think they need. |
The OpenShift documentation hasn't mentioned dasd since 4.5: https://docs.openshift.com/container-platform/4.5/installing/installing_ibm_z/installing-ibm-z.html |
we removed dasd from our build artifacts in RHCOS. At some point in the future we should be able to remove the code that supports building them (or probably more likely: switch to using OSBuild where support was never added). |
If i understand correctly @dustymabe last comment, we can close this since #3800 was merged ? |
I'm trying to understand what are the fundamental differences between our
dasd
andmetal4k
artifacts on s390x. We build bothdasd
andmetal4k
for RHCOS but from looking at the code in the following two files and some recent logs from pipeline runs from RHCOS 4.15 I can't really find significant differences.Here are the two files in COSA I'm comparing:
Here are the two logs from the recent 4.15 run I'm comparing:
The only real changes I see between the two runs is:
metal4k
--no-x86-bios-bootloader
is passed tocreate_disk.sh
, but this is a no-op on s390x so it is harmless.vdb
and notvdc
. I don't think this is significant.So that begs the question: what is the actual difference between the
dasd
image and themetal4k
image on s390x? They both areraw
disk images. They both haveignition.platform.id=metal
.What am I missing?
The text was updated successfully, but these errors were encountered: