Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify documentation - fill parameter only used for numerical data #152

Open
gtmaskall opened this issue Dec 12, 2023 Discussed in #151 · 0 comments
Open

Clarify documentation - fill parameter only used for numerical data #152

gtmaskall opened this issue Dec 12, 2023 Discussed in #151 · 0 comments
Labels
documentation Documentation related issue good first issue Good for newcomers

Comments

@gtmaskall
Copy link

Discussed in #151

Originally posted by gtmaskall December 12, 2023
The default behaviour of make_geocube with categorical data is to append a nodata string to the <varname>_categories variable. This makes sense from a Python indexing perspective inasmuch as the corresponding integer code for this is -1. This seems to override the fill argument. Again this makes sense with the use of -1 and the position of nodata. But if I'm correct in this, the documentation could be tightened up a little to clarify that fill only applies to numerical data.

@snowman2 snowman2 added good first issue Good for newcomers documentation Documentation related issue labels Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related issue good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants