From 58c1499fdcb08792d8723e5e0b052ea1ed96fb73 Mon Sep 17 00:00:00 2001 From: Cortisiko Date: Sun, 4 Aug 2024 17:33:03 -0400 Subject: [PATCH 1/7] avoid committing local builds remotely --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index a091a3b5..1c958079 100644 --- a/.gitignore +++ b/.gitignore @@ -2,3 +2,4 @@ __pycache__ tests/.coverage tests/.test-results +dist/* From 653495d6d2aeee6e3116a6c342ea5e24e77d5867 Mon Sep 17 00:00:00 2001 From: Cortisiko Date: Sun, 1 Sep 2024 17:27:32 -0400 Subject: [PATCH 2/7] unnecessary comment --- app/financials/analyze.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/financials/analyze.py b/app/financials/analyze.py index 1c496c98..fa77defb 100644 --- a/app/financials/analyze.py +++ b/app/financials/analyze.py @@ -13,8 +13,6 @@ price_data: Handles price data retrieval. ticker: Handles ticker symbol retrieval. -Constants: - ERROR_MESSAGE (str): Error message to return in case of invalid stock symbol. Functions: get_company_sector(ticker_symbol) From 548dca1f61dd41913fe1afbec67e7482af936e4d Mon Sep 17 00:00:00 2001 From: Cortisiko Date: Mon, 7 Oct 2024 20:00:31 -0400 Subject: [PATCH 3/7] try using multiprocessing libary --- user_interface.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/user_interface.py b/user_interface.py index 090e3b91..122a3dcb 100644 --- a/user_interface.py +++ b/user_interface.py @@ -6,6 +6,7 @@ import tkinter as tk import sys import os +import multiprocessing from PIL import Image, ImageTk from app.pages import ( @@ -116,10 +117,13 @@ def on_closing(self): if __name__ == "__main__": + + multiprocessing.freeze_support() # This prevents double-execution + try: app = UserInterFace() app.geometry("1200x800") app.protocol("WM_DELETE_WINDOW", app.on_closing) app.mainloop() except KeyboardInterrupt as e: - print("closing app") + print("Closing app") From aa53a591be630553629291607996d9eeb5b89618 Mon Sep 17 00:00:00 2001 From: Cortisiko Date: Mon, 7 Oct 2024 20:08:05 -0400 Subject: [PATCH 4/7] fix spacing --- app/pages/base_page.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/pages/base_page.py b/app/pages/base_page.py index 1913a1f2..77031f19 100644 --- a/app/pages/base_page.py +++ b/app/pages/base_page.py @@ -11,6 +11,8 @@ from tkmacosx import Button else: from tkinter import Button + + class BasePage(tk.Frame): # pylint: disable=too-many-instance-attributes """ @@ -25,6 +27,7 @@ class BasePage(tk.Frame): yearly_text (str): The text value for the annual option in the radio button. bg_color (str): The background color of the frame. """ + # pylint: disable=line-too-long def __init__(self, parent, controller, title, quarterly_text, yearly_text, bg_color='#2C3E50', fg_color='white'): From f4ec577d2a6ad21b5887914c2c75932fe57d72e9 Mon Sep 17 00:00:00 2001 From: Cortisiko Date: Mon, 7 Oct 2024 20:48:14 -0400 Subject: [PATCH 5/7] update pylint config --- .pylintrc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.pylintrc b/.pylintrc index 5b5d582d..a16e7eeb 100644 --- a/.pylintrc +++ b/.pylintrc @@ -289,8 +289,9 @@ exclude-too-few-public-methods= # R0901) ignored-parents= + # Maximum number of arguments for function / method. -max-args=5 +max-args=8 # Maximum number of attributes for a class (see R0902). max-attributes=15 From 27b91a1a048c08638231e209482ce9ef015e5ec3 Mon Sep 17 00:00:00 2001 From: Cortisiko Date: Tue, 8 Oct 2024 09:56:11 -0400 Subject: [PATCH 6/7] undo changes to linting config --- .pylintrc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.pylintrc b/.pylintrc index a16e7eeb..5b5d582d 100644 --- a/.pylintrc +++ b/.pylintrc @@ -289,9 +289,8 @@ exclude-too-few-public-methods= # R0901) ignored-parents= - # Maximum number of arguments for function / method. -max-args=8 +max-args=5 # Maximum number of attributes for a class (see R0902). max-attributes=15 From 578cee1523b5d98cbcab65d048e94eb42e81d7a6 Mon Sep 17 00:00:00 2001 From: Cortisiko Date: Tue, 8 Oct 2024 10:03:35 -0400 Subject: [PATCH 7/7] add new linting rule --- .pylintrc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.pylintrc b/.pylintrc index 5b5d582d..a793c284 100644 --- a/.pylintrc +++ b/.pylintrc @@ -319,6 +319,8 @@ max-statements=50 # Minimum number of public methods for a class (see R0903). min-public-methods=2 +# Maximum number of positional arguments (see R0917). +max-positional-arguments = 10 [EXCEPTIONS]