From 794ede7bb410aef888dd81680e3065a866575fc1 Mon Sep 17 00:00:00 2001
From: chatton <cian@interchain.io>
Date: Tue, 15 Oct 2024 11:43:12 +0100
Subject: [PATCH] chore: added test case to verify proof failure

---
 modules/core/04-channel/v2/keeper/msg_server_test.go | 10 +++++++++-
 testing/endpoint_v2.go                               |  2 +-
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/modules/core/04-channel/v2/keeper/msg_server_test.go b/modules/core/04-channel/v2/keeper/msg_server_test.go
index e864e7a01c6..a75dfdee074 100644
--- a/modules/core/04-channel/v2/keeper/msg_server_test.go
+++ b/modules/core/04-channel/v2/keeper/msg_server_test.go
@@ -334,6 +334,7 @@ func (suite *KeeperTestSuite) TestMsgAcknowledgement() {
 	var (
 		path   *ibctesting.Path
 		packet channeltypesv2.Packet
+		ack    channeltypesv2.Acknowledgement
 	)
 	testCases := []struct {
 		name     string
@@ -380,6 +381,13 @@ func (suite *KeeperTestSuite) TestMsgAcknowledgement() {
 			},
 			expError: channeltypesv2.ErrInvalidPacket,
 		},
+		{
+			name: "failure: failed membership verification",
+			malleate: func() {
+				ack.AcknowledgementResults[0].RecvPacketResult.Acknowledgement = mock.MockFailPacketData
+			},
+			expError: errors.New("failed packet acknowledgement verification"),
+		},
 	}
 	for _, tc := range testCases {
 		suite.Run(tc.name, func() {
@@ -399,7 +407,7 @@ func (suite *KeeperTestSuite) TestMsgAcknowledgement() {
 			suite.Require().NoError(err)
 
 			// Construct expected acknowledgement
-			ack := channeltypesv2.Acknowledgement{
+			ack = channeltypesv2.Acknowledgement{
 				AcknowledgementResults: []channeltypesv2.AcknowledgementResult{
 					{
 						AppName: mockv2.ModuleNameB,
diff --git a/testing/endpoint_v2.go b/testing/endpoint_v2.go
index cd00e5a6441..62a0ac69c12 100644
--- a/testing/endpoint_v2.go
+++ b/testing/endpoint_v2.go
@@ -43,7 +43,7 @@ func (endpoint *Endpoint) MsgRecvPacket(packet channeltypesv2.Packet) error {
 	return endpoint.Counterparty.UpdateClient()
 }
 
-// MsgAcknowledgePacket
+// MsgAcknowledgePacket sends a MsgAcknowledgement on the associated endpoint with the provided packet and ack.
 func (endpoint *Endpoint) MsgAcknowledgePacket(packet channeltypesv2.Packet, ack channeltypesv2.Acknowledgement) error {
 	packetKey := hostv2.PacketAcknowledgementKey(packet.DestinationChannel, packet.Sequence)
 	proof, proofHeight := endpoint.Counterparty.QueryProof(packetKey)