Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proto3 json as ICS 27 encoding type #989

Open
colin-axner opened this issue Jun 21, 2023 · 4 comments
Open

Add proto3 json as ICS 27 encoding type #989

colin-axner opened this issue Jun 21, 2023 · 4 comments
Labels
app Application layer. implementation Tracking an external implementation of the spec.

Comments

@colin-axner
Copy link
Contributor

See discussion on cosmos/ibc-go#3246 for justification of the addition.

Related issue: #634

@colin-axner colin-axner added the app Application layer. label Jun 21, 2023
@crodriguezvega crodriguezvega added the implementation Tracking an external implementation of the spec. label Jul 3, 2023
@Teja2045
Copy link

@colin-axner, is this still open? I think cosmos/ibc-go#3796 should close this. Or do let me know if anything else needs to be done.

@colin-axner
Copy link
Contributor Author

Yes I believe it is still open unless the specs in this repo have been updated?

@crodriguezvega
Copy link
Contributor

Wondering if we need to add this to spec... Currently the spec doesn't really specify any possible encoding formats and seems to leave this to the implementations... what do you think, @AdityaSripal?

@colin-axner
Copy link
Contributor Author

colin-axner commented Mar 12, 2024

It's not possible to integrate correctly these applications without knowing the expected encoding. My comment here is an example where using proto3 json vs standard json is not compatible

It is a problem that the spec doesn't specify encoding formats

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Application layer. implementation Tracking an external implementation of the spec.
Projects
Status: No status
Development

No branches or pull requests

3 participants