Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive Clone and Debug on HostFunctionsManager #299

Open
Farhad-Shabani opened this issue Apr 6, 2024 · 0 comments
Open

Derive Clone and Debug on HostFunctionsManager #299

Farhad-Shabani opened this issue Apr 6, 2024 · 0 comments
Labels
rust Issues pertaining to the Rust implementation

Comments

@Farhad-Shabani
Copy link
Member

Background

In ibc-rs, to accommodate users who wish to leverage a custom HostFunctionsProvider (Related issue) for utilizing custom hashing functions in verifying their MerkleProof, the approaches there involve introducing <H: HostFunctionsProvider> as a generic type and making our Tendermint ClientState definition generic over H. However, since that ClientState relies on Clone and Debug traits in various parts of the ibc-rs implementation, The lack of these derivations on the HostFunctionsManager limits our options.

Proposal

At min, derive Clone and Debug on HostFunctionsManager, and see if it makes sense to require these two for the HostFunctionsProvider trait as well.

@crodriguezvega crodriguezvega added the rust Issues pertaining to the Rust implementation label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Issues pertaining to the Rust implementation
Projects
None yet
Development

No branches or pull requests

2 participants