You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In ICS20Transfer.sol we have two functions that "unwrap" (and more) the packet data: _unwrapSendPacketData() and _unwrapReceivePacketData().
They are hard to read and reason about, and if we could find a better way to handle all the logic it contains, it would be a big improvement to the ICS20Transfer code.
The UnwrappedPacketData has become big, complex and contains a lot of information that might be better suited elsewhere (some fields might just be kept local since they are not used many places, like the originatorChainIsSource field).
The text was updated successfully, but these errors were encountered:
In
ICS20Transfer.sol
we have two functions that "unwrap" (and more) the packet data:_unwrapSendPacketData()
and_unwrapReceivePacketData()
.They are hard to read and reason about, and if we could find a better way to handle all the logic it contains, it would be a big improvement to the ICS20Transfer code.
The
UnwrappedPacketData
has become big, complex and contains a lot of information that might be better suited elsewhere (some fields might just be kept local since they are not used many places, like theoriginatorChainIsSource
field).The text was updated successfully, but these errors were encountered: