Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple the abi files #87

Open
srdtrk opened this issue Jul 31, 2024 · 0 comments
Open

Decouple the abi files #87

srdtrk opened this issue Jul 31, 2024 · 0 comments
Labels
contracts Issues concerning the solidity contracts enhancement New feature or request needs discussion This issue needs more discussion before its implementation nice to have

Comments

@srdtrk
Copy link
Member

srdtrk commented Jul 31, 2024

Right now, all the required abi are generated in the single file contracts/abi/SP1ICS07Tendermint.json. I often find myself adding new structs to the public api using apiPublicTypes function.

It should be possible to get rid of this function by breaking down the abi to different json files for each interface contract
@srdtrk srdtrk added enhancement New feature or request nice to have contracts Issues concerning the solidity contracts labels Jul 31, 2024
@srdtrk srdtrk changed the title Decouple the abi definitions Decouple the abi files Jul 31, 2024
@srdtrk srdtrk added the needs discussion This issue needs more discussion before its implementation label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contracts Issues concerning the solidity contracts enhancement New feature or request needs discussion This issue needs more discussion before its implementation nice to have
Projects
IBC-GO Eureka
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@srdtrk