Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET: Test methods should not use blocking task operations #112

Open
amotl opened this issue Oct 31, 2023 · 1 comment
Open

.NET: Test methods should not use blocking task operations #112

amotl opened this issue Oct 31, 2023 · 1 comment

Comments

@amotl
Copy link
Member

amotl commented Oct 31, 2023

There are a few admonitions on PRs related to .NET/C#.

Test methods should not use blocking task operations, as they can cause deadlocks. Use an async test method and await instead. (https://xunit.net/xunit.analyzers/rules/xUnit1031)

image

-- https://github.com/crate/cratedb-examples/pull/111/files, see section "Unchanged files with check annotations".

@amotl
Copy link
Member Author

amotl commented Oct 31, 2023

Currently, there seem to be other admonitions, only .NET/C# submits them the PR.

While it does not look that much important, it is important to reduce regular reporting and notification noise on this repository, and to take care of those details rigidly, so that significant signals received from this repository stand out, and will bring their value in notifying us early about any havocs which may have been introduced to the software components tested here in one way or another.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant