Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: TxReplacement is not implemented #1557

Open
yihuang opened this issue Aug 26, 2024 · 1 comment · May be fixed by #1563
Open

feat: TxReplacement is not implemented #1557

yihuang opened this issue Aug 26, 2024 · 1 comment · May be fixed by #1563

Comments

@yihuang
Copy link
Collaborator

yihuang commented Aug 26, 2024 •
edited
Loading

sdk mempool PriorityMempool support tx replacement through a callback, but it's nil for now, we might want to implement the callback to support tx replacement by nonce with higher gas price.
yihuang added a commit to yihuang/cronos that referenced this issue Sep 2, 2024
@yihuang
Problem: tx is not replaced by priority
3f0b777 
Closes: crypto-org-chain#1557

Solution:
- add TxReplacement callback, only replace if priority is higher
@yihuang yihuang linked a pull request Sep 2, 2024 that will close this issue
Draft
13 tasks
@yihuang
Copy link
Collaborator Author

yihuang commented Oct 17, 2024

blocker: check tx don't allow same nonce txs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Problem: tx is not replaced by priority yihuang/cronos
1 participant
@yihuang