Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoreleaseTime is never set to non-zero (server does not reflect contract's AutoreleaseTime) #4

Open
coinop-logan opened this issue Nov 16, 2018 · 1 comment

Comments

@coinop-logan
Copy link
Member

coinop-logan commented Nov 16, 2018

The event reaction code (as written) doesn't have access to the contract's state (to fetch the newly set autoreleaseTime). This is stopping us from implementing autorelease warning notifications.

One solution is to add in direct contract monitoring to the code. This could be part of mainLoop or its own thread.

Another option is to edit the event in the contract to include the newly set autoreleaseTime. Oddly, that might be both easier and better in the long run... Maybe the event "should" contain that information.

@coinop-logan coinop-logan changed the title Contracts should be monitored directly, not just updated in response to events AutoreleaseTime is never set to non-zero (server does not reflect contract's AutoreleaseTime) Nov 16, 2018
@coinop-logan
Copy link
Member Author

To clarify, above I was referring to the ClaimStarted event. This event should probably include the newly calculated autoreleaseTime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant