Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for vmware VMs #3

Open
iddq opened this issue Dec 18, 2019 · 1 comment
Open

fix for vmware VMs #3

iddq opened this issue Dec 18, 2019 · 1 comment

Comments

@iddq
Copy link

iddq commented Dec 18, 2019

realdev = open(devname, O_RDWR);

-       realdev = open(devname, O_RDWR);
+       realdev = open(devname, O_RDWR|O_NOCTTY|O_NONBLOCK);
@danielinux
Copy link
Owner

tty's may be used as controlling TTY in some cases, so O_NOCTTY by default is not an option.
I don't see any valid reasons to make the socket non blocking either.

Perhaps both could be configuration options if it makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants