Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert fails when using with Braintree PHP installed and having const "Braintree" on the saved class #155

Open
RobIsHere opened this issue Apr 5, 2017 · 1 comment

Comments

@RobIsHere
Copy link

Because of the is_subclass_of check in php-rql
https://github.com/danielmewes/php-rql/blob/master/rdb/DatumConverter.php#L37

saving something like this fails because the check triggers the autoloader that in turn reveals an unfortunate code in Braintree's lib.

class User {
    const PAYMENT_PROVIDER = 'Braintree'
}
@Geekimo
Copy link

Geekimo commented Dec 24, 2017

I've submitted a PR about this one. #148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants